Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage the place for CRD OpenAPI that differs between versions #2554

Merged
merged 9 commits into from
Feb 16, 2020
Merged

Stage the place for CRD OpenAPI that differs between versions #2554

merged 9 commits into from
Feb 16, 2020

Conversation

n3wscott
Copy link
Contributor

  • Use versioned OpenAPI for CRDs in eventing for resources that are being promoted.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 12, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 12, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@n3wscott
Copy link
Contributor Author

/cc @dprotaso

@n3wscott
Copy link
Contributor Author

FLAKE

--- FAIL: TestEventTransformationForTrigger (1.09s)
    --- FAIL: TestEventTransformationForTrigger/TestEventTransformationForTrigger-{InMemoryChannel_messaging.knative.dev/v1alpha1} (257.60s)

/retest

matzew
matzew reviewed Feb 13, 2020
View reviewed changes
config/core/resources/apiserversource.yaml Outdated
type: string
description: "the target URI. If ref is provided, this must be relative URI reference."
- type: object
description: "DEPRECATED: a reference to a Kubernetes object from which to retrieve the target URI."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we remove this after 0.13 cut ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely we will keep it for v1alpha1 until v1alpha1 drops off

@vaikas vaikas mentioned this pull request Feb 13, 2020
Closed
@matzew
Copy link
Member

matzew commented Feb 13, 2020

from a quick look, this LGTM...

but leaving it for @dprotaso

@vaikas
Copy link
Contributor

vaikas commented Feb 13, 2020

/lgtm
/hold
so @dprotaso can take a looksie too :)

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

I actually haven't done this for serving yet knative/serving#912 - and I've allowed all fields for now

https://github.com/knative/serving/blob/1208aca19b1619799ef24d20c45c9fdce3367609/config/core/resources/configuration.yaml#L26-L33

I would just ensure your schema is 'structural' as per these rules (which is a non-obvious read when you're tired)

https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#specifying-a-structural-schema.

Thus you're the pioneers here!

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2020
@n3wscott
Copy link
Contributor Author

/unhold

Validated all new openapi schemas are structural.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2020
@n3wscott
Copy link
Contributor Author

/retest

2 similar comments
@n3wscott
Copy link
Contributor Author

/retest

@n3wscott
Copy link
Contributor Author

/retest

@matzew
Copy link
Member

matzew commented Feb 15, 2020 via email

@n3wscott
Copy link
Contributor Author

@matzew you can not use excitement, prow is startled easily.

@matzew
Copy link
Member

matzew commented Feb 16, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2020
@knative-prow-robot knative-prow-robot merged commit 4a46925 into knative:master Feb 16, 2020
@matzew matzew mentioned this pull request Feb 17, 2020
Closed
@n3wscott n3wscott mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@yolocs yolocs yolocs approved these changes

@vaikas vaikas Awaiting requested review from vaikas

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@matzew matzew

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@n3wscott @matzew @vaikas @knative-prow-robot @dprotaso @yolocs @googlebot