Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker class based defaults #7631

Merged
merged 48 commits into from
Aug 22, 2024
Merged

Broker class based defaults #7631

merged 48 commits into from
Aug 22, 2024

Commits on Jan 26, 2024

  1. First draft of the default broker class code 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d7ee0ca View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    66dfc36 View commit details
    Browse the repository at this point in the history

  2. Change the default broker class config 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    662c214 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Run codegen 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3c11b02 View commit details
    Browse the repository at this point in the history

  2. Refactor the code 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8145609 View commit details
    Browse the repository at this point in the history

  3. Codegen 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0f3b4a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    eca570c View commit details
    Browse the repository at this point in the history

  2. Fix the build error and run code gen 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5f61000 View commit details
    Browse the repository at this point in the history

  3. Fix the build error in the tests 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b8a649e View commit details
    Browse the repository at this point in the history

  4. Fix the build error in the tests 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    73eb74d View commit details
    Browse the repository at this point in the history

  5. Modify the current existing test, and add more test cases 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    03f8cab View commit details
    Browse the repository at this point in the history

  6. Modify the current existing test, and add more test cases 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6395453 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    15fa1c4 View commit details
    Browse the repository at this point in the history

  2. Pass in the actual broker name instead of leaving it empty 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    2480d40 View commit details
    Browse the repository at this point in the history

  3. Modify the condition to check whether Different Namespace is allowed … 

    …according to the default configs

Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a70189f View commit details
    Browse the repository at this point in the history

  4. Revert the brokerSpec.Name change. 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    76592bb View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Fix the failing unit tests by adding the default config for the defaults 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9b5abf3 View commit details
    Browse the repository at this point in the history

  2. Fix the failing unit tests 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4a2da5f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3813fa6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Fix the review comments 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d0a1660 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    51c88f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c678829 View commit details
    Browse the repository at this point in the history

  2. Update pkg/apis/config/defaults.go 

    Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
    @Leo6Leo @creydr
    Leo6Leo and creydr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    28c30e6 View commit details
    Browse the repository at this point in the history

  3. Change the tests to be table form 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d37c5e3 View commit details
    Browse the repository at this point in the history

  4. Check if the brokerClassName is the default broker class for the whol… 

    …e cluster

Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f602457 View commit details
    Browse the repository at this point in the history

  5. Fixed the build error 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b5a6863 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    37c637a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge remote-tracking branch 'origin/main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5f6d615 View commit details
    Browse the repository at this point in the history

  2. fix: instead of always passing the empty className, pass in the varia… 

    …ble instead

Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ef6c1c5 View commit details
    Browse the repository at this point in the history

  3. fix: brokerClass is a string pointer. If the value is null but pointe… 

    …r has value, it will pass. So this commit fix that problem.

Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4106cbc View commit details
    Browse the repository at this point in the history

  4. feat: adding some temporary test cases for testing purposes 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    77779fd View commit details
    Browse the repository at this point in the history

  5. feat: adding some temporary test cases for testing purposes 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fcf9916 View commit details
    Browse the repository at this point in the history

  6. fix: fix the failing tests 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    606578c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge remote-tracking branch 'origin/main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3bcdf2f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge remote-tracking branch 'origin/main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed May 14, 2024
    Configuration menu
    Copy the full SHA
    78c73e2 View commit details
    Browse the repository at this point in the history

  2. fix: fix FIXME, the issue that can potentially cause SegFault 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aef75f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5333a8a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. fix: fix the failing rabbitmq issue 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    602427d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. fix: remove the trailing whitespace 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8c1e77f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. fix: update the comments 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2f36466 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. feat: add the high level summary for the code 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d9df59f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'main' into default-broker-class

    @Leo6Leo
    Leo6Leo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    96ae24c View commit details
    Browse the repository at this point in the history

  2. fix: fix the review comments 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b928021 View commit details
    Browse the repository at this point in the history

  3. fix: fix the review comments 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    27eb33c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. fix: fix Calum's review comments 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fe6d9dc View commit details
    Browse the repository at this point in the history

  2. fix: fix failed unit test caused by the latest review comment fix 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b4f7060 View commit details
    Browse the repository at this point in the history

  3. fix: fix failed unit test caused by the latest review comment fix 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    7a7260f View commit details
    Browse the repository at this point in the history

  4. feat: add the test for the deprecating default broker config feature 

    Signed-off-by: Leo Li <leoli@redhat.com>
    @Leo6Leo
    Leo6Leo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0e62b00 View commit details
    Browse the repository at this point in the history