Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imc dispatcher doesn't have duplicate reporting of metrics #7870

Merged

Conversation

Cali0707
Copy link
Member

Fixes #7869

We were always recording the metrics once, and then if there was http or https we were recording the metric a second time. This fixes that to only do the recording of metrics once with the scheme set.

Proposed Changes

  • Remove the extra call to record the metrics

Release Note

:bug: The IMC dispatcher metrics now correctly record the metrics once per event when there is only one request scheme, instead of twice

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from aliok and pierDipi April 25, 2024 14:25
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr

@knative-prow knative-prow bot requested a review from creydr April 25, 2024 14:25
@creydr
Copy link
Member

creydr commented Apr 25, 2024

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member

creydr commented Apr 25, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.54%. Comparing base (7e1c082) to head (c48a17e).
Report is 19 commits behind head on main.

Files Patch % Lines
pkg/channel/fanout/fanout_event_handler.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7870      +/-   ##
==========================================
+ Coverage   69.22%   69.54%   +0.32%     
==========================================
  Files         339      340       +1     
  Lines       19494    15740    -3754     
==========================================
- Hits        13494    10946    -2548     
+ Misses       5337     4124    -1213     
- Partials      663      670       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@knative-prow knative-prow bot merged commit 46e3677 into knative:main Apr 25, 2024
32 of 38 checks passed
@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #7873

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #7874

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew pushed a commit to matzew/eventing that referenced this pull request Apr 26, 2024
…ive#7870)

fix: imc dispatcher doesn't have duplicate reporting

Signed-off-by: Calum Murray <cmurray@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Apr 26, 2024
…ive#7870) (#595)

fix: imc dispatcher doesn't have duplicate reporting

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Apr 26, 2024
…ive#7870)

fix: imc dispatcher doesn't have duplicate reporting

Signed-off-by: Calum Murray <cmurray@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Jul 9, 2024
…ive#7870) (#596)

fix: imc dispatcher doesn't have duplicate reporting

Signed-off-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imc dispatcher metrics show duplicate entries with event_scheme=""
3 participants