-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: imc dispatcher doesn't have duplicate reporting of metrics #7870
fix: imc dispatcher doesn't have duplicate reporting of metrics #7870
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.14 |
@creydr: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.13 |
@creydr: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7870 +/- ##
==========================================
+ Coverage 69.22% 69.54% +0.32%
==========================================
Files 339 340 +1
Lines 19494 15740 -3754
==========================================
- Hits 13494 10946 -2548
+ Misses 5337 4124 -1213
- Partials 663 670 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for fixing
@creydr: new pull request created: #7873 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@creydr: new pull request created: #7874 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ive#7870) fix: imc dispatcher doesn't have duplicate reporting Signed-off-by: Calum Murray <cmurray@redhat.com>
…ive#7870) fix: imc dispatcher doesn't have duplicate reporting Signed-off-by: Calum Murray <cmurray@redhat.com>
Fixes #7869
We were always recording the metrics once, and then if there was http or https we were recording the metric a second time. This fixes that to only do the recording of metrics once with the scheme set.
Proposed Changes
Release Note