Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fake client reactor for subject access reviews #7908

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented May 8, 2024

This should fix the issues with subject access reviews we are seeing in unit tests

Proposed Changes

  • Add a reactor that handles create requests for subject access reviews

Note: this can probably be improved upon (for example also looking at clusterroles/clusterrolebindings), but this should be good enough for what we are testing now so I would like to merge this first before making improvements

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@knative-prow knative-prow bot requested a review from creydr May 8, 2024 17:42
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
@knative-prow knative-prow bot requested a review from Leo6Leo May 8, 2024 17:42
@Cali0707
Copy link
Member Author

Cali0707 commented May 8, 2024

/cc @yijie-04 @pierDipi

@yijie-04 if these changes look good to you, feel free to comment /lgtm!

@knative-prow knative-prow bot requested review from pierDipi and yijie-04 May 8, 2024 17:42
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 69.02%. Comparing base (7e1c082) to head (da2d5d6).
Report is 34 commits behind head on main.

Files Patch % Lines
pkg/reconciler/testing/v1/factory.go 0.00% 23 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7908      +/-   ##
==========================================
- Coverage   69.22%   69.02%   -0.20%     
==========================================
  Files         339      341       +2     
  Lines       19494    15853    -3641     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4236    -1101     
- Partials      663      674      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yijie-04
Copy link
Contributor

yijie-04 commented May 9, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@knative-prow knative-prow bot merged commit fa46a45 into knative:main May 9, 2024
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants