Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eventtype-auto-create feature flag for e2e tests #7940

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented May 27, 2024

Enabling the eventtype-auto-create feature flag for e2e tests.

@creydr creydr requested review from pierDipi and Cali0707 May 27, 2024 09:57
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels May 27, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@creydr
Copy link
Member Author

creydr commented May 27, 2024

@Cali0707: as a follow up on #7934 (comment)

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.51%. Comparing base (74253dd) to head (1a5076a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7940      +/-   ##
==========================================
- Coverage   69.56%   69.51%   -0.06%     
==========================================
  Files         344      344              
  Lines       15994    15994              
==========================================
- Hits        11127    11119       -8     
- Misses       4182     4189       +7     
- Partials      685      686       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link

knative-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a3a2ac0 into knative:main May 27, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants