Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppliedEventPoliciesStatus type #7999

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 12, 2024

Fixes #7975

Proposed Changes

  • 🎁 Add AppliedEventPoliciesStatus type
  • 🎁 Add AppliedEventPoliciesStatus to Brokers status
  • 🎁 Add AppliedEventPoliciesStatus to Parallel status
  • 🎁 Add AppliedEventPoliciesStatus to Sequence status
  • 🎁 Add AppliedEventPoliciesStatus to InMemoryChannel status

@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi June 12, 2024 11:07
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 12, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (67ceb9e) to head (e6d9058).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7999      +/-   ##
==========================================
+ Coverage   67.56%   67.67%   +0.11%     
==========================================
  Files         355      361       +6     
  Lines       16551    16625      +74     
==========================================
+ Hits        11182    11251      +69     
- Misses       4678     4684       +6     
+ Partials      691      690       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr requested a review from pierDipi June 12, 2024 14:23
@creydr
Copy link
Member Author

creydr commented Jun 13, 2024

@pierDipi can you recheck?

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link

knative-prow bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Jun 13, 2024

/retest

@knative-prow knative-prow bot merged commit ea8f0fd into knative:main Jun 13, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AppliedEventPoliciesStatus type
2 participants