-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add metrics for OIDC #8015
base: main
Are you sure you want to change the base?
Changes from 6 commits
df83a87
0f31830
bb39854
2878e92
b44273f
6fe5a92
3974884
82f8327
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As this is not only relevant to broker-filters anymore, should we move this StatsReporter to a dedicated package and make it more generic? E.g. Then you could also change the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So for example:
and then for example for the broker/trigger:
And then we call this e.g. in
and use it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this looks good? @creydr By passing the statsReporter to the verifier, and pass the reportArgs when verifying happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this an optional argument (e.g. by using a configuration-option function as we do for example in
eventing/pkg/reconciler/testing/v1/broker.go
Lines 35 to 44 in 825202f
type BrokerOption func(*v1.Broker)
)? This allows us to add options, without the need to update the packages immediately which use theNewOIDCTokenVerifier
.