Fix test case in TestCreateExpectedEventPatterns #8022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestCreateExpectedEventPatterns
will start to fail with go 1.22 (see #8019 (comment)):The test was actually never totally correct and only the last test case was tested. See https://go.dev/blog/loopvar-preview:
This PR addresses it and fixes the test. Actually the tests is the same as the one for t0 which was setup correctly:
eventing/test/rekt/features/broker/topology_test.go
Lines 101 to 122 in 67958c6