-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes Version Check to Installation Script #8025
Conversation
Hi @prajjwalyd. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! @prajjwalyd ! I tested the script, and it works perfectly on my end.
The only thing that I am not sure is where to put the check_k8s_version.go
file, as currently under the /hack
folder, there are already many files.
Thank you for reviewing it, @Leo6Leo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start @prajjwalyd !
My vote would be to put it in a subdirectory of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8025 +/- ##
==========================================
+ Coverage 67.79% 67.92% +0.13%
==========================================
Files 363 367 +4
Lines 16899 17323 +424
==========================================
+ Hits 11456 11767 +311
- Misses 4735 4823 +88
- Partials 708 733 +25 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks @prajjwalyd !!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, prajjwalyd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7813
Proposed Changes
Please categorize your changes:
🎁 Added a minimum Kubernetes version check in
install.sh
.check_k8s_version.go
connects to a Kubernetes cluster using the kubeconfig file, then checks if the cluster's version is compatible with the minimum required version specified by Knative. If the version is compatible, it prints a success message; otherwise, it logs an error and exits.When using k8s v1.27.0:
When using k8s v1.28.0: (minimum specified version)
Pre-review Checklist
Release Note
Docs