-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List applying policies in job sink #8064
List applying policies in job sink #8064
Conversation
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Hi @rahulii. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: rahulii <r.sawra@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8064 +/- ##
==========================================
+ Coverage 67.92% 68.04% +0.12%
==========================================
Files 366 367 +1
Lines 17154 17249 +95
==========================================
+ Hits 11651 11737 +86
+ Misses 4781 4780 -1
- Partials 722 732 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
/ok-to-test |
/test reconciler-tests |
Signed-off-by: rahulii <r.sawra@gmail.com>
"k8s.io/apimachinery/pkg/runtime" | ||
utilrand "k8s.io/apimachinery/pkg/util/rand" | ||
clientgotesting "k8s.io/client-go/testing" | ||
"k8s.io/utils/pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
we already use that package for job sink:
"k8s.io/utils/ptr" |
Let's stay consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, Thanks!
Signed-off-by: rahulii <r.sawra@gmail.com>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, rahulii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @rahulii |
Fixes #8062
Proposed Changes
Pre-review Checklist
Release Note
Docs