List applying policies in Parallel #8083

rahulii · 2024-07-08T12:06:25Z

Proposed Changes

🎁 List EventPolicies in the Parallel .status.policies, which apply for it.
🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

List applying EventPolicies in Parallel status

Docs

Signed-off-by: rahulii <r.sawra@gmail.com>

knative-prow · 2024-07-08T12:06:28Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2024-07-08T12:12:25Z

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.87%. Comparing base (fe6bd56) to head (405b1eb).
Report is 11 commits behind head on main.

Files	Patch %	Lines
pkg/apis/flows/v1/parallel_lifecycle.go	50.00%	4 Missing ⚠️
pkg/reconciler/testing/v1/parallel.go	84.21%	3 Missing ⚠️
pkg/reconciler/parallel/controller.go	88.23%	1 Missing and 1 partial ⚠️
pkg/reconciler/parallel/parallel.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8083      +/-   ##
==========================================
+ Coverage   67.84%   67.87%   +0.03%     
==========================================
  Files         367      367              
  Lines       17349    17474     +125     
==========================================
+ Hits        11770    11861      +91     
- Misses       4844     4873      +29     
- Partials      735      740       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: rahulii <r.sawra@gmail.com>

rahulii · 2024-07-08T20:01:40Z

/ok-to-test

Leo6Leo

Thank you for the PR! @rahulii , great job! Could you also take a look at the formatting issue that is reported by reviewdog?

pkg/apis/flows/v1/parallel_lifecycle.go

pkg/reconciler/testing/v1/parallel.go

Signed-off-by: rahulii <r.sawra@gmail.com>

rahulii · 2024-07-10T11:38:58Z

Thank you for the PR! @rahulii , great job! Could you also take a look at the formatting issue that is reported by reviewdog?

@Leo6Leo not sure if this PR has any changes related to reviewdog failure? It's showing boilerplate text issues. Can you PTAL?

Cali0707 · 2024-07-10T12:28:43Z

not sure if this PR has any changes related to reviewdog failure? It's showing boilerplate text issues. Can you PTAL?

Recently reviewdog started reporting failures on the whole project (not just modified files in the PR). We're trying to go through and fix those issues, so unless the reviewdog failure is on one of the files you changed in this PR don't worry about it - we are working to fix it all

rahulii · 2024-07-10T12:49:38Z

not sure if this PR has any changes related to reviewdog failure? It's showing boilerplate text issues. Can you PTAL?

Recently reviewdog started reporting failures on the whole project (not just modified files in the PR). We're trying to go through and fix those issues, so unless the reviewdog failure is on one of the files you changed in this PR don't worry about it - we are working to fix it all

thanks for the update @Cali0707 👍🏼

Leo6Leo

/lgtm
Thanks for the great work! It looks good to me right now.
/cc @Cali0707

Cali0707

Looks good, just a few things I think we need to fix up and then this should be good to merge - nice work @rahulii !

pkg/reconciler/parallel/controller.go

pkg/reconciler/parallel/controller_test.go

pkg/reconciler/parallel/parallel.go

Signed-off-by: rahulii <r.sawra@gmail.com>

Cali0707 · 2024-07-11T14:53:39Z

pkg/reconciler/parallel/controller.go

+	var globalResync func()
+	featureStore := feature.NewStore(logging.FromContext(ctx).Named("feature-config-store"), func(name string, value interface{}) {
+		if globalResync != nil {
+			globalResync()
+		}
+	})
+	featureStore.WatchConfigs(cmw)


Nice! We just need to use this store in the parallelreconciler.NewImpl(ctx, r, ...options) now (line 58). See for example how that is done here:

eventing/pkg/reconciler/inmemorychannel/controller/controller.go

Lines 105 to 109 in bb2e0a3

impl := inmemorychannelreconciler.NewImpl(ctx, r, func(impl *controller.Impl) controller.Options {

return controller.Options{

ConfigStore: featureStore,

}

})

sure, thanks for reminding @Cali0707 👍🏼

done, PTAL!

Signed-off-by: rahulii <r.sawra@gmail.com>

Cali0707

/lgtm
/approve

Thanks for all your work here @rahulii !

knative-prow · 2024-07-12T12:32:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lifecycle changes for evebtpolicies in parallel

f969e54

Signed-off-by: rahulii <r.sawra@gmail.com>

knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2024

knative-prow bot requested review from Cali0707 and lionelvillard July 8, 2024 12:06

controller changes for eventpolicies and add tests

59cd4e3

Signed-off-by: rahulii <r.sawra@gmail.com>

rahulii marked this pull request as ready for review July 8, 2024 12:56

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024

knative-prow bot requested a review from creydr July 8, 2024 12:56

rahulii changed the title ~~List applying policies in job sink~~ List applying policies in Parallel Jul 8, 2024

knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 8, 2024

Leo6Leo self-requested a review July 9, 2024 12:37

Leo6Leo reviewed Jul 9, 2024

View reviewed changes

pkg/apis/flows/v1/parallel_lifecycle.go Show resolved Hide resolved

pkg/reconciler/testing/v1/parallel.go Outdated Show resolved Hide resolved

fix review comments

1a20bbc

Signed-off-by: rahulii <r.sawra@gmail.com>

Leo6Leo reviewed Jul 10, 2024

View reviewed changes

knative-prow bot assigned Leo6Leo Jul 10, 2024

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024

Cali0707 requested changes Jul 10, 2024

View reviewed changes

pkg/reconciler/parallel/controller.go Outdated Show resolved Hide resolved

pkg/reconciler/parallel/controller_test.go Show resolved Hide resolved

pkg/reconciler/parallel/parallel.go Show resolved Hide resolved

knative-prow bot assigned Cali0707 Jul 10, 2024

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024

rahulii added 2 commits July 11, 2024 13:36

fix to review comments

a010ff9

Signed-off-by: rahulii <r.sawra@gmail.com>

add featurestore to watch configmaps

5873a1e

Signed-off-by: rahulii <r.sawra@gmail.com>

Cali0707 reviewed Jul 11, 2024

View reviewed changes

add featurestore to reconciler impl

405b1eb

Signed-off-by: rahulii <r.sawra@gmail.com>

Cali0707 approved these changes Jul 12, 2024

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024

knative-prow bot merged commit e73f2c9 into knative:main Jul 12, 2024
35 of 36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List applying policies in Parallel #8083

List applying policies in Parallel #8083

rahulii commented Jul 8, 2024

knative-prow bot commented Jul 8, 2024

codecov bot commented Jul 8, 2024 •

edited

Loading

rahulii commented Jul 8, 2024

Leo6Leo left a comment

rahulii commented Jul 10, 2024

Cali0707 commented Jul 10, 2024

rahulii commented Jul 10, 2024

Leo6Leo left a comment

Cali0707 left a comment

Cali0707 Jul 11, 2024

rahulii Jul 12, 2024

rahulii Jul 12, 2024

Cali0707 left a comment

knative-prow bot commented Jul 12, 2024

	impl := inmemorychannelreconciler.NewImpl(ctx, r, func(impl *controller.Impl) controller.Options {
	return controller.Options{
	ConfigStore: featureStore,
	}
	})

List applying policies in Parallel #8083

List applying policies in Parallel #8083

Conversation

rahulii commented Jul 8, 2024

Proposed Changes

Pre-review Checklist

knative-prow bot commented Jul 8, 2024

codecov bot commented Jul 8, 2024 • edited Loading

Codecov Report

rahulii commented Jul 8, 2024

Leo6Leo left a comment

Choose a reason for hiding this comment

rahulii commented Jul 10, 2024

Cali0707 commented Jul 10, 2024

rahulii commented Jul 10, 2024

Leo6Leo left a comment

Choose a reason for hiding this comment

Cali0707 left a comment

Choose a reason for hiding this comment

Cali0707 Jul 11, 2024

Choose a reason for hiding this comment

rahulii Jul 12, 2024

Choose a reason for hiding this comment

rahulii Jul 12, 2024

Choose a reason for hiding this comment

Cali0707 left a comment

Choose a reason for hiding this comment

knative-prow bot commented Jul 12, 2024

codecov bot commented Jul 8, 2024 •

edited

Loading