-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove ingress option from delivery format #8086
fix: remove ingress option from delivery format #8086
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
/cc @matzew |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8086 +/- ##
==========================================
- Coverage 67.85% 67.85% -0.01%
==========================================
Files 367 367
Lines 17356 17354 -2
==========================================
- Hits 11777 11775 -2
Misses 4844 4844
Partials 735 735 ☔ View full report in Codecov by Sentry. |
type FormatType string | ||
|
||
const ( | ||
DeliveryFormatJson FormatType = "json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not calling it structured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an idea from #8080 (comment), I'm personally happy either way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I was guess it was along those lines.
OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes the delivery format option we had before, and aligns the code with the approach used for other similar fields in the delivery spec.
Proposed Changes