Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tls dispatcher tests all use different ports #8088

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 9, 2024

Fixes #7955

Proposed Changes

  • Use a different port for each receiver in the tls dispatcher tests so that they don't fail due to a port being in use

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

/cc @Leo6Leo @matzew

@knative-prow knative-prow bot requested review from aliok and pierDipi July 9, 2024 17:53
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2024
@knative-prow knative-prow bot requested review from Leo6Leo and matzew July 9, 2024 17:53
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (71d7e5e) to head (b3d9fed).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8088   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files         367      367           
  Lines       17354    17354           
=======================================
  Hits        11775    11775           
  Misses       4844     4844           
  Partials      735      735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

knative-prow bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 57b52ea into knative:main Jul 10, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky] pkg/kncloudevents.TestDispatchMessageToTLSEndpointWithReply
2 participants