Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CESQL v1 #8103

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Update CESQL v1 #8103

merged 2 commits into from
Jul 16, 2024

Conversation

Cali0707
Copy link
Member

Updates the CESQL version being used to support the v1 spec

Knative Eventing now supports the CESQL v1 specification. IMPORTANT: there are some breaking changes between the previous v0.1 specification and the current v1 specification.

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

/cc @matzew

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 15, 2024
@knative-prow knative-prow bot requested review from matzew, aslom and Leo6Leo July 15, 2024 17:21
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (e73f2c9) to head (90c7bd2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8103      +/-   ##
==========================================
- Coverage   67.88%   67.87%   -0.02%     
==========================================
  Files         368      368              
  Lines       17552    17552              
==========================================
- Hits        11915    11913       -2     
- Misses       4893     4894       +1     
- Partials      744      745       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
Will the upstream package cut a new release soon?

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link

knative-prow bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Jul 16, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@knative-prow knative-prow bot merged commit 1316277 into knative:main Jul 16, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants