Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventPolicy reconciliation for Parallel #8112

Merged
merged 20 commits into from
Aug 9, 2024

Conversation

rahulii
Copy link
Contributor

@rahulii rahulii commented Jul 24, 2024

Fixes #7984

Proposed Changes

  • 🎁 Reconcile EventPolicies for Parallel
  • 🎁 Reconcile IngressChannel event policies

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Reconcile EventPolicies for Parallel's channel.

Docs

Signed-off-by: rahulii <r.sawra@gmail.com>
Copy link

knative-prow bot commented Jul 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2024
@knative-prow knative-prow bot requested review from creydr and pierDipi July 24, 2024 12:10
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 34.22819% with 98 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (5c81d76) to head (0bd3e69).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/reconciler/parallel/resources/eventpolicy.go 0.00% 68 Missing ⚠️
pkg/reconciler/parallel/parallel.go 62.96% 17 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8112      +/-   ##
==========================================
- Coverage   68.06%   67.80%   -0.27%     
==========================================
  Files         369      370       +1     
  Lines       17726    17875     +149     
==========================================
+ Hits        12066    12120      +54     
- Misses       4901     4983      +82     
- Partials      759      772      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii rahulii marked this pull request as ready for review July 29, 2024 09:44
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2024
@knative-prow knative-prow bot requested a review from Leo6Leo July 29, 2024 09:44
@rahulii rahulii changed the title create eventpolicies for parallel channel reconcile eventpolicies for parallel channel Jul 29, 2024
Signed-off-by: rahulii <r.sawra@gmail.com>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2024
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: rahulii <r.sawra@gmail.com>
@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 31, 2024

And also from the failed reconciler test here, it seems like some of the changes break the existing Parallel OIDC tests.

Signed-off-by: rahulii <r.sawra@gmail.com>
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2024
Signed-off-by: rahulii <r.sawra@gmail.com>
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this @rahulii. I left a few comments on this. Hope this helps, otherwise let us know.

pkg/reconciler/parallel/resources/eventpolicy.go Outdated Show resolved Hide resolved
pkg/reconciler/parallel/parallel.go Outdated Show resolved Hide resolved
pkg/reconciler/parallel/parallel.go Outdated Show resolved Hide resolved
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii rahulii requested a review from creydr August 8, 2024 11:22
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
Copy link
Contributor Author

rahulii commented Aug 8, 2024

I am taking a look at failed E2E tests !

@creydr
Copy link
Member

creydr commented Aug 8, 2024

/retest

Signed-off-by: rahulii <r.sawra@gmail.com>
@creydr creydr changed the title reconcile eventpolicies for parallel channel Add EventPolicy reconciliation for Parallel Aug 9, 2024
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this @rahulii and including all the reviews 👍
I only left a comment/question, but looks LGTM for me in general

pkg/reconciler/parallel/parallel.go Outdated Show resolved Hide resolved
@creydr
Copy link
Member

creydr commented Aug 9, 2024

/test reconciler-tests

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks a lot for your work on this @rahulii

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link

knative-prow bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@knative-prow knative-prow bot merged commit c521efb into knative:main Aug 9, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel Reconciler: Create EventPolicies for Parallel
3 participants