Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence reconciler reads and watch the config-features configmap #8124

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 1, 2024

In the sequence reconciler feature.FromContext(ctx) always returns the default feature flags as the context is not populated with the ConfigStore

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link

knative-prow bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2024
@knative-prow knative-prow bot requested review from aliok and creydr August 1, 2024 15:33
@pierDipi pierDipi requested a review from Leo6Leo August 1, 2024 15:35
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (a9abf3c) to head (a41ab29).

Files Patch % Lines
pkg/reconciler/sequence/controller.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8124      +/-   ##
==========================================
- Coverage   67.88%   67.88%   -0.01%     
==========================================
  Files         368      368              
  Lines       17554    17565      +11     
==========================================
+ Hits        11917    11924       +7     
- Misses       4891     4893       +2     
- Partials      746      748       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 1, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@knative-prow knative-prow bot merged commit ff37e4e into knative:main Aug 1, 2024
36 checks passed
@Cali0707
Copy link
Member

/cherry-pick release-1.15

@Cali0707
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@Cali0707: #8124 failed to apply on top of branch "release-1.14":

Applying: Sequence reconciler reads and watch the config-features configmap
Using index info to reconstruct a base tree...
M	pkg/reconciler/sequence/controller.go
M	pkg/reconciler/sequence/sequence.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/sequence/sequence.go
Auto-merging pkg/reconciler/sequence/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/sequence/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Sequence reconciler reads and watch the config-features configmap
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #8179

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants