Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable controller default health probes in the IMC dispatcher #8125

Commits on Aug 1, 2024

  1. Disable controller default health probes in the IMC dispatcher

    The IMC dispatcher is using the same server receiving events
    for k8s readiness and liveness probes, so we don't need the
    controller internal health server to be running.
    
    The controller internal health server is using the same port
    which leads to this error:
    
    ```
    2024-07-31T15:58:53.582Z	error	inmemorychannel-dispatcher	sharedmain/main.go:334	Error while running server	{"commit": "b7bfc92", "knative.dev/pod": "imc-dispatcher-696d94588d-j7fr5", "error": "listen tcp :8080: bind: address already in use"}
    knative.dev/pkg/injection/sharedmain.MainWithConfig
    	knative.dev/pkg@v0.0.0-20240716082220-4355f0c73608/injection/sharedmain/main.go:334
    knative.dev/pkg/injection/sharedmain.MainWithContext
    	knative.dev/pkg@v0.0.0-20240716082220-4355f0c73608/injection/sharedmain/main.go:209
    main.main
    	knative.dev/eventing/cmd/in_memory/channel_dispatcher/main.go:47
    runtime.main
    	runtime/proc.go:271
    ```
    
    Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
    pierDipi committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4071782 View commit details
    Browse the repository at this point in the history