Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AuthZ conformance e2e test suite #8150

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Add AuthZ conformance e2e test suite #8150

merged 8 commits into from
Aug 13, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 12, 2024 •
edited
Loading

Fixes #8149

Proposed Changes

  • 🎁 Add AuthZ conformance e2e test suite

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2024
@creydr creydr mentioned this pull request Aug 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (7a90257) to head (5278381).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8150   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         370      370           
  Lines       17945    17946    +1     
=======================================
+ Hits        12151    12152    +1     
  Misses       5020     5020           
  Partials      774      774

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

/test reconciler-tests

@creydr creydr mentioned this pull request Aug 12, 2024
Closed
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@creydr creydr force-pushed the add-conformance-suite-for-authz branch from 1e78077 to 7360a94 Compare August 12, 2024 18:05
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@creydr creydr force-pushed the add-conformance-suite-for-authz branch from 9c00027 to 93f1aa5 Compare August 12, 2024 18:16
@creydr
Copy link
Member Author

creydr commented Aug 12, 2024

/test unit-tests

@creydr creydr changed the title [WIP] Add AuthZ conformance e2e test suite Add AuthZ conformance e2e test suite Aug 12, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@creydr
Copy link
Member Author

creydr commented Aug 12, 2024

/cc @Cali0707 @mgencur @rahulii
This is ready for review. Could you PTAL?

@knative-prow knative-prow bot requested a review from rahulii August 12, 2024 19:15
@rahulii
Copy link
Contributor

rahulii commented Aug 13, 2024

Thanks @creydr , PR looks good overall!

@creydr
Copy link
Member Author

creydr commented Aug 13, 2024

@Cali0707 could you PTAL?

Cali0707
Cali0707 reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise this looks good to me!

test/rekt/features/authz/addressable_authz_conformance.go Outdated Show resolved Hide resolved
test/rekt/features/authz/addressable_authz_conformance.go Outdated Show resolved Hide resolved
creydr and others added 2 commits August 13, 2024 17:03
@creydr @Cali0707
Update test/rekt/features/authz/addressable_authz_conformance.go
53d5c7e 
Co-authored-by: Calum Murray <cmurray@redhat.com>
@creydr @Cali0707
Update test/rekt/features/authz/addressable_authz_conformance.go
5278381 
Co-authored-by: Calum Murray <cmurray@redhat.com>
@creydr creydr requested a review from Cali0707 August 13, 2024 15:03
Cali0707
Cali0707 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 71d5d5f into knative:main Aug 13, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@mgencur mgencur Awaiting requested review from mgencur

@rahulii rahulii Awaiting requested review from rahulii

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AuthZ conformance e2e test suite
5 participants
@creydr @dsimansk @rahulii @Cali0707 @knative-prow-robot