Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: propagate EventPolicy filter to underlying Channels EventPolicy #8163

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 16, 2024

The filters of the parent policy of Channels/Parallels & Sequences are not propagated to the underlying channels EventPolicies.
This PR fixes it.

Found on adding e2e tests in #8162

@creydr creydr requested a review from Cali0707 August 16, 2024 14:44
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@knative-prow knative-prow bot requested review from aslom and pierDipi August 16, 2024 14:44
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.52%. Comparing base (2b92299) to head (7cea68e).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/reconciler/parallel/resources/eventpolicy.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8163   +/-   ##
=======================================
  Coverage   67.51%   67.52%           
=======================================
  Files         371      371           
  Lines       17974    17980    +6     
=======================================
+ Hits        12136    12141    +5     
- Misses       5066     5067    +1     
  Partials      772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for catching & fixing this @creydr !!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
Copy link

knative-prow bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

/test unit-tests

looks like a flake..

@knative-prow knative-prow bot merged commit b57ac3a into knative:main Aug 16, 2024
35 of 36 checks passed
@creydr creydr deleted the fix-ep-filter-propagation branch August 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants