Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JobSink to have ObservedGeneration in status #8168

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix JobSink to have ObservedGeneration in status #8168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/core/resources/jobsink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ spec:
type:
description: 'Type of condition.'
type: string
observedGeneration:
description: ObservedGeneration is the 'Generation' of the Service that was last processed by the controller.
type: integer
format: int64
additionalPrinterColumns:
- name: URL
type: string
Expand Down
6 changes: 3 additions & 3 deletions test/rekt/features/jobsink/jobsink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func Success() *feature.Feature {
f.Setup("install job sink", jobsink.Install(jobSink, jobsink.WithForwarderJob(sinkURL.String())))

f.Setup("jobsink is addressable", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsReady(jobSink))

f.Requirement("install source", eventshub.Install(source,
eventshub.StartSenderToResource(jobsink.GVR(), jobSink),
Expand Down Expand Up @@ -97,7 +97,7 @@ func SuccessTLS() *feature.Feature {
f.Setup("install job sink", jobsink.Install(jobSink, jobsink.WithForwarderJob(sinkURL.String())))

f.Setup("jobsink is addressable", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsReady(jobSink))

f.Requirement("install source", eventshub.Install(source,
eventshub.StartSenderToResourceTLS(jobsink.GVR(), jobSink, nil),
Expand Down Expand Up @@ -142,7 +142,7 @@ func OIDC() *feature.Feature {
f.Setup("install job sink", jobsink.Install(jobSink, jobsink.WithForwarderJob(sinkURL.String())))

f.Setup("jobsink is addressable", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsAddressable(jobSink))
f.Setup("jobsink is ready", jobsink.IsReady(jobSink))

f.Requirement("install source", eventshub.Install(source,
eventshub.StartSenderToResource(jobsink.GVR(), jobSink),
Expand Down
Loading