Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobSink: Reject unauthorized requests #8169

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 20, 2024

Fixes #8166

Proposed Changes

  • 🎁 Reject unauthorized requests in the JobSink

Release Note

JobSink: Reject unauthorized requests

WIP, as it needs the following before:

@knative-prow knative-prow bot requested review from Leo6Leo and mgencur August 20, 2024 10:39
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Aug 20, 2024
@creydr creydr changed the title [WIPJ obSink: Reject unauthorized requests [WIPJ JobSink: Reject unauthorized requests Aug 20, 2024
@creydr creydr requested a review from pierDipi August 20, 2024 10:43
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (5fc4c0f) to head (d97ddc2).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/jobsink/main.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8169      +/-   ##
==========================================
+ Coverage   67.46%   67.48%   +0.02%     
==========================================
  Files         371      371              
  Lines       18001    17995       -6     
==========================================
  Hits        12144    12144              
+ Misses       5085     5079       -6     
  Partials      772      772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr force-pushed the jobsink-reject-unauthorized-requests branch from 26d6436 to d97ddc2 Compare August 20, 2024 13:32
@creydr creydr changed the title [WIPJ JobSink: Reject unauthorized requests JobSink: Reject unauthorized requests Aug 20, 2024
@creydr
Copy link
Member Author

creydr commented Aug 20, 2024

Rebased as #8168 and #8167 merged

@creydr
Copy link
Member Author

creydr commented Aug 20, 2024

/test reconciler-tests

@creydr
Copy link
Member Author

creydr commented Aug 20, 2024

@pierDipi I think this is ready for review

@creydr
Copy link
Member Author

creydr commented Aug 21, 2024

@pierDipi could you check on this?
/cc @pierDipi

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 477588c into knative:main Aug 22, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobSink: Reject unauthorized requests
2 participants