-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make auth package indepent from eventpolicy informer #8195
Make auth package indepent from eventpolicy informer #8195
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8195 +/- ##
==========================================
+ Coverage 67.47% 67.48% +0.01%
==========================================
Files 371 371
Lines 18036 18036
==========================================
+ Hits 12169 12171 +2
+ Misses 5088 5087 -1
+ Partials 779 778 -1 ☔ View full report in Codecov by Sentry. |
830605a
to
d1439f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently the pkg/auth package depends on the eventpolicy informer (through the tokenverifier), requiring everything what imports
knative.dev/eventing/pkg/auth
to have permissions to read&list EventPolicies.This leads to the following issues e.g. for PingSource (which does not need the TokenVerifier):
This PR addresses it and removes the dependency in the TokenVerifier to the EventPolicy informer. In addition it renames the
auth.OIDCTokenVerifier
toauth.Verifier
as this includes AuthN and AuthZ.