Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update tekton to latest versions #1753

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

lance
Copy link
Member

@lance lance commented May 24, 2023

Changes

Fixes: #1716

  • 🧹 Bumps tekton/cli and tekton/pipelines to 0.31.0 and 0.47.0 respectively.

/cc @jrangelramos

@knative-prow knative-prow bot requested a review from jrangelramos May 24, 2023 01:21
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2023
@lance
Copy link
Member Author

lance commented May 24, 2023

/kind techdebt

lance added 2 commits May 23, 2023 21:22
Fixes: knative#1716

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@lance lance requested a review from zroubalik May 24, 2023 01:29
@lance lance added this to the Release 1.11 milestone May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.19 🎉

Comparison is base (bf01e64) 62.38% compared to head (6df29ed) 62.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   62.38%   62.57%   +0.19%     
==========================================
  Files          98       99       +1     
  Lines       13066    13213     +147     
==========================================
+ Hits         8151     8268     +117     
- Misses       4130     4151      +21     
- Partials      785      794       +9     
Flag Coverage Δ
e2e-test 38.07% <0.00%> (-0.31%) ⬇️
e2e-test-oncluster 33.58% <55.00%> (-0.37%) ⬇️
e2e-test-oncluster-runtime 28.90% <60.00%> (?)
e2e-test-runtime-go 27.48% <0.00%> (?)
e2e-test-runtime-node 28.58% <0.00%> (?)
e2e-test-runtime-python 28.58% <0.00%> (?)
e2e-test-runtime-quarkus 28.71% <0.00%> (?)
e2e-test-runtime-springboot 27.65% <0.00%> (?)
e2e-test-runtime-typescript 28.71% <0.00%> (?)
integration-tests 48.05% <0.00%> (-2.45%) ⬇️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 50.36% <15.00%> (+0.13%) ⬆️
unit-tests-windows-latest 49.57% <15.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipelines/tekton/pipeplines_provider.go 56.32% <22.22%> (-0.73%) ⬇️
pkg/pipelines/tekton/client.go 42.30% <83.33%> (+4.80%) ⬆️
pkg/pipelines/tekton/resources.go 97.18% <100.00%> (+7.04%) ⬆️
pkg/pipelines/tekton/tasks.go 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

matejvasek commented May 24, 2023

@lance this probably requires Go higher than 1.18. I think atomic.Pointer was added in 1.19.

@jrangelramos
Copy link
Contributor

Hi @lance maybe we could upgrade CI scripts as well and see how it goes... https://github.com/knative/func/blob/main/hack/tekton.sh#L25

@jrangelramos
Copy link
Contributor

btw it works fine with OSH Pipelines 1.10

lance added 3 commits May 24, 2023 15:22
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek
Copy link
Contributor

/approve
/lgtm

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@knative-prow
Copy link

knative-prow bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member Author

lance commented May 26, 2023

@knative/func-reviewers ptal

@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@matejvasek
Copy link
Contributor

@lance you might need to override the linter

@lance
Copy link
Member Author

lance commented May 26, 2023

/override "style / suggester / shell"

@knative-prow
Copy link

knative-prow bot commented May 26, 2023

@lance: Overrode contexts on behalf of lance: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member Author

lance commented May 26, 2023

/override "style / suggester / github_actions"

@knative-prow
Copy link

knative-prow bot commented May 26, 2023

@lance: Overrode contexts on behalf of lance: style / suggester / github_actions

In response to this:

/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit dd7c8bd into knative:main May 26, 2023
matejvasek added a commit to matejvasek/faas that referenced this pull request Aug 23, 2023
Fixes: knative#1716

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek added a commit to matejvasek/faas that referenced this pull request Aug 23, 2023
Fixes: knative#1716

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
openshift-merge-robot pushed a commit to openshift-knative/kn-plugin-func that referenced this pull request Aug 24, 2023
* deps: update tekton to latest versions (knative#1753)

Fixes: knative#1716

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: update CI Go version

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: update golangci-lit version

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: update github.com/tektoncd/cli

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: delete replacement of tekton lib version

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/techdebt lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support tekton v0.44.*+
4 participants