Fix PaC build #2314
Merged
Fix PaC build #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matejvasek
commented
May 21, 2024
•
matejvasek
commented
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
knative-prow
bot
added
the
size/S
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
+ Coverage 60.19% 65.76% +5.57%
==========================================
Files 128 128
Lines 14831 11490 -3341
==========================================
- Hits 8927 7556 -1371
+ Misses 4990 2980 -2010
- Partials 914 954 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
PTAL @lkingland @gauron99 |
|
this should fix #2185 right? |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PTAL @jrangelramos |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
May 30, 2024
* fix: default NS for PaC Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: make error non-fatal Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: pass correct image to PaC Signed-off-by: Matej Vašek <mvasek@redhat.com> * chore: enable gitlab test --------- Signed-off-by: Matej Vašek <mvasek@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
May 30, 2024
* Fix PaC build (knative#2314) * fix: default NS for PaC Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: make error non-fatal Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: pass correct image to PaC Signed-off-by: Matej Vašek <mvasek@redhat.com> * chore: enable gitlab test --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: pipeline run yaml format for newer PaC (knative#2317) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Update install-gitlab.sh --------- Signed-off-by: Matej Vašek <mvasek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.