Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On cluster s2i build for Go #2466

Closed
wants to merge 8 commits into from
Closed

On cluster s2i build for Go #2466

wants to merge 8 commits into from

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Aug 26, 2024 •
edited
Loading

Changes

  • Enabled on-cluster s2i build for Go by adding scaffolding task into the tekton pipeline.
  • Update git-clone to the latest rootless version. This required some uid/gid harmonization. Alternative would be to make util image rootfull see alt PR: On cluster s2i build for Go (alternative version) #2471.

/kind enhancement

Fixes #2443

feat: enabled on-cluster s2i build for Go

@matejvasek
Prepare util image to accomodate multiple cmds
d5fec1f 
As of now func-util image has only one command of our own -- "deploy".
This commits prepares grounds for one additional command named "scaffolding".
The commands will be implemented in one binary and dispatched over
argv[0] using symlinks. Kinda like busybox does.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Add scaffolding for on-cluster build
91fd4c1 
Added new build step in tekton pipeline that scaffolds main() for Go
porject when using s2i builder.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Better docker build caching
e892963 
This will cache dependencies between docker builds.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.54098% with 32 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (4775ad9) to head (57d5371).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cmd/func-util/main.go 0.00% 31 Missing ⚠️
pkg/pipelines/tekton/tasks.go 96.42% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
+ Coverage   61.22%   66.64%   +5.42%     
==========================================
  Files         130      130              
  Lines       15354    11996    -3358     
==========================================
- Hits         9400     7995    -1405     
+ Misses       5029     3039    -1990     
- Partials      925      962      +37
Flag Coverage Δ
e2e-test 36.68% <0.00%> (-0.09%) ⬇️
e2e-test-oncluster 33.53% <93.33%> (+0.21%) ⬆️
e2e-test-oncluster-runtime 29.51% <93.33%> (?)
e2e-test-runtime-go 26.70% <0.00%> (?)
e2e-test-runtime-node 26.09% <0.00%> (?)
e2e-test-runtime-python 26.09% <0.00%> (?)
e2e-test-runtime-quarkus 26.19% <0.00%> (?)
e2e-test-runtime-rust 25.24% <0.00%> (?)
e2e-test-runtime-springboot 25.27% <0.00%> (?)
e2e-test-runtime-typescript 26.18% <0.00%> (?)
integration-tests 52.73% <47.54%> (+2.32%) ⬆️
unit-tests 50.91% <45.90%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested review from gauron99, lkingland and matzew and removed request for maximilien August 26, 2024 20:47
@lkingland
Copy link
Member

This looks great so far 👍🏻

matejvasek and others added 4 commits August 27, 2024 14:57
@matejvasek
fixup: perms
942dec9 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
fixup: remove broken check
69360db 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
fixup: remove test because of 'no space left on device'
c55a776 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Updated git-clone task
7f2ee94
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @matzew

@matejvasek matejvasek marked this pull request as ready for review August 27, 2024 20:13
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@knative-prow knative-prow bot requested a review from vyasgun August 27, 2024 20:13
@matejvasek matejvasek removed the request for review from vyasgun August 27, 2024 20:20
@matejvasek
fixup: uid/gid
57d5371 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Copy link
Contributor Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@matejvasek matejvasek closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

@matzew matzew Awaiting requested review from matzew

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build a Go function with s2i directly on the cluster
2 participants
@matejvasek @lkingland