Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export GOFLAGS in Makefile #2493

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Export GOFLAGS in Makefile #2493

merged 1 commit into from
Sep 11, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

Copy link

knative-prow bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for nainaz September 11, 2024 17:26
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.97%. Comparing base (749f755) to head (bfd6b6a).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (749f755) and HEAD (bfd6b6a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (749f755) HEAD (bfd6b6a)
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
unit-tests-windows-latest 1 0
e2e-test 1 0
integration-tests 1 0
e2e-test-oncluster 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2493       +/-   ##
===========================================
- Coverage   61.53%   50.97%   -10.57%     
===========================================
  Files         129      127        -2     
  Lines       15344    11926     -3418     
===========================================
- Hits         9442     6079     -3363     
- Misses       4974     5138      +164     
+ Partials      928      709      -219     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@matejvasek
Copy link
Contributor Author

@ReToCode @dsimansk plz override the codecov/project check.

Copy link

knative-prow bot commented Sep 11, 2024

@dsimansk: /override requires failed status contexts to operate on, but none was given

In response to this:

/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/override codecov/project

Copy link

knative-prow bot commented Sep 11, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit cbf98fd into main Sep 11, 2024
35 of 36 checks passed
@matejvasek matejvasek deleted the matejvasek-patch-1 branch September 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants