Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures in OCP prow CI #2503

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix test failures in OCP prow CI #2503

merged 2 commits into from
Sep 16, 2024

Conversation

matejvasek
Copy link
Contributor

Ensure that ServeRepo() make copy of repo from ./testdata and serves the repo from that copy.

Changes

/kind

Fixes #

Release Note

Docs

@matejvasek
Fix test failures in OCP prow CI
a6bff20 
Ensure that ServeRepo() make copy of repo from ./testdata and serves the
repo from that copy.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 15, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Ensure that ServeRepo() make copy of repo from ./testdata and serves the repo from that copy.

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (84f4caf) to head (09e4038).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/testing.go 54.83% 8 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
+ Coverage   60.72%   66.98%   +6.26%     
==========================================
  Files         129      129              
  Lines       15351    11959    -3392     
==========================================
- Hits         9322     8011    -1311     
+ Misses       5131     2976    -2155     
- Partials      898      972      +74
Flag Coverage Δ
e2e-test 36.60% <ø> (ø)
e2e-test-oncluster 33.41% <ø> (?)
e2e-test-oncluster-runtime 29.45% <ø> (?)
e2e-test-runtime-go 26.61% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 26.00% <ø> (?)
e2e-test-runtime-quarkus 26.09% <ø> (?)
e2e-test-runtime-rust 25.12% <ø> (?)
e2e-test-runtime-springboot 25.16% <ø> (?)
e2e-test-runtime-typescript 26.08% <ø> (?)
integration-tests 53.06% <54.83%> (+2.37%) ⬆️
unit-tests 51.25% <54.83%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
fixup: typo
09e4038 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek matejvasek requested review from gauron99 and removed request for nainaz September 15, 2024 21:07
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @lkingland @gauron99

matzew
matzew approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 42ed4d8 into knative:main Sep 16, 2024
39 checks passed
@matejvasek matejvasek mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@lkingland lkingland Awaiting requested review from lkingland

@dsimansk dsimansk Awaiting requested review from dsimansk

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @matzew