Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use the sum.golang.org service, too many 410s #10

Merged
merged 1 commit into from
Nov 2, 2020
Merged

do not use the sum.golang.org service, too many 410s #10

merged 1 commit into from
Nov 2, 2020

Conversation

n3wscott
Copy link

@n3wscott n3wscott commented Nov 2, 2020

We are still getting a lot of 410's when doing update deps, we are using direct go mod mode, but there is a second checksum service that is also in-play. Removing that service.

Ref: https://twitter.com/mattomata/status/1323296883838627840

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 2, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2020
mattmoor
mattmoor reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@knative-prow-robot knative-prow-robot merged commit 8ea85e9 into knative:master Nov 2, 2020
@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2020

I'm worried people will forget this is turned off and not realize we're exposing ourselves

Can we add retries for CI?

@n3wscott n3wscott mentioned this pull request Nov 3, 2020
Open
slinkydeveloper added a commit to slinkydeveloper/hack that referenced this pull request Nov 25, 2020
@slinkydeveloper
Observer test code (knative#10)
a566af4 
* Observer test code

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Forgot vendor code

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@peterfeifanchen peterfeifanchen Awaiting requested review from peterfeifanchen

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n3wscott @knative-prow-robot @dprotaso @mattmoor