Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos and upstream library.sh changes #196

Open
wants to merge 1 commit into
base: vendor-cleanup
Choose a base branch
from

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jul 14, 2022

Part of knative/infra#134

I'm putting this in a separate branch so the changes can be synced by knobots and avoid shipping this to other repos via go module.

Will merge this to main once all repos have been fixed.

/cc @kvmware @evankanderson

@knative-prow
Copy link

knative-prow bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2022
@krsna-m
Copy link
Contributor

krsna-m commented May 30, 2023

/lgtm
/hold unhold when ready

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants