Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate calling kubetest2 via kntest #230

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Deprecate calling kubetest2 via kntest #230

merged 6 commits into from
Aug 18, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Sep 26, 2022 •
edited
Loading

Changes

Fixes #

/cc @cardil

@knative-prow
Copy link

knative-prow bot commented Sep 26, 2022

@upodroid: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

/cc @cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested a review from cardil September 26, 2022 16:05
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2022
cardil
cardil reviewed Sep 27, 2022
View reviewed changes
infra-library.sh Outdated Show resolved Hide resolved
@cardil
Copy link
Contributor

cardil commented Sep 27, 2022 •
edited
Loading

Unit tests needs to be updated. They are failing now because they were expecting a call to kntest.

Hit me directly, if you need a help with updating them...

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@upodroid upodroid mentioned this pull request May 9, 2023
Merged
@krsna-m
Copy link
Contributor

krsna-m commented May 30, 2023

/lgtm
/hold til announcement time passes

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@upodroid
Copy link
Member Author

/retest-required

@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@dprotaso
Copy link
Member

/hold

I see some test is commented out

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
dprotaso
dprotaso reviewed Aug 17, 2023
View reviewed changes
e2e-tests.sh Outdated Show resolved Hide resolved
infra-library.sh Outdated Show resolved Hide resolved
performance-tests.sh Show resolved Hide resolved
test/unit/presubmit_test.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@dprotaso
Copy link
Member

dprotaso commented Aug 18, 2023 via email

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2023
dprotaso
dprotaso approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

holding for nit - drop if you don't want to do it in this PR

e2e-tests.sh
@@ -133,6 +131,7 @@ E2E_SCRIPT=""
function initialize() {
local run_tests=0
local custom_flags=()
local extra_gcloud_flags=()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revisit this in a separate PR

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023
@dprotaso
Copy link
Member

/hold cancel
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 18, 2023
@knative-prow knative-prow bot merged commit 9cc05a3 into knative:main Aug 18, 2023
18 checks passed
@upodroid upodroid mentioned this pull request Aug 18, 2023
Closed
5 tasks
@upodroid upodroid mentioned this pull request Aug 28, 2023
Merged
@upodroid upodroid mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil left review comments

@dprotaso dprotaso dprotaso approved these changes

Assignees

@dprotaso dprotaso

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upodroid @cardil @krsna-m @dprotaso @knative-prow-robot