Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added knative-extensions #293

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

davidhadas
Copy link
Contributor

@davidhadas davidhadas commented May 24, 2023

Add support for knative-extensions
removed knative-sandbox

@knative-prow knative-prow bot requested review from mgencur and upodroid May 24, 2023 08:18
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
@davidhadas
Copy link
Contributor Author

Any reason why test does not pass?

@davidhadas
Copy link
Contributor Author

/retest

1 similar comment
@dsimansk
Copy link
Contributor

/retest

library.sh Outdated Show resolved Hide resolved
@davidhadas davidhadas changed the title HoldTillRename: Rename knative-sandbox to knative-extension Added knative-extensions Aug 2, 2023
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can replace knative-sandbox instead

library.sh Outdated Show resolved Hide resolved
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@knative-prow knative-prow bot merged commit d7fde30 into knative:main Aug 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants