Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell format warning in library.sh #298

Closed
wants to merge 3 commits into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 8, 2023

As per title, this patch fixes shell format warning in library.sh.
It was discovered by https://github.com/knative/hack/pull/297/files but didn't fix because it didn't touch all of them.

@knative-prow knative-prow bot requested a review from evankanderson July 8, 2023 14:40
@knative-prow
Copy link

knative-prow bot commented Jul 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from mgencur July 8, 2023 14:40
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2023
@nak3
Copy link
Contributor Author

nak3 commented Jul 8, 2023

/cc @kvmware @upodroid

@knative-prow knative-prow bot requested review from krsna-m and upodroid July 8, 2023 14:44
@knative-prow
Copy link

knative-prow bot commented Jul 8, 2023

@nak3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_hack_main c8dfe4f link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Contributor Author

nak3 commented Jul 8, 2023

Closing as the warning is produced forever and one of the reviewdog's suggestion:

[shellcheck] reported by reviewdog 🐶

Raw Output:
library.sh:286:-        local status=(`echo -n ${pod} | cut -f2 -d' ' | tr '/' ' '`)
library.sh:286:+        local status=($(echo -n "${pod}" | cut -f2 -d' ' | tr '/' ' '))

I changed it as 8354146 then integration test started failing...

@nak3 nak3 closed this Jul 8, 2023
@upodroid
Copy link
Member

upodroid commented Jul 8, 2023

You can configure shellcheck to ignore a specific line.

# shellcheck disable=SC2059 Replace it with the correct id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants