Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e-kind.sh #307

Closed
wants to merge 1 commit into from
Closed

Conversation

davidhadas
Copy link
Contributor

manual renaming

@knative-prow
Copy link

knative-prow bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidhadas
Once this PR has been reviewed and has the lgtm label, please assign kvmware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2023
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linting errors suggested by the linter?

@krsna-m
Copy link
Contributor

krsna-m commented Aug 18, 2023

We was instructed to do so https://cloud-native.slack.com/archives/C04LY4M2G49/p1692208028070579?thread_ts=1692207828.557749&cid=C04LY4M2G49 here before as well.

This will not be merged with failing tests
/hold
until lint tests are fixed

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@davidhadas
Copy link
Contributor Author

davidhadas commented Aug 18, 2023

The owners of this repo need to fix it.
I am not going to fix repos who have broken lint and other tests not related to renaming.

We was instructed to do so https://cloud-native.slack.com/archives/C04LY4M2G49/p1692208028070579?thread_ts=1692207828.557749&cid=C04LY4M2G49 here before as well.

@kvmware
oh well, if you instructed... obedience is the only way forward...
Your attitude is unacceptable.
And not helpful in any way.

@krsna-m
Copy link
Contributor

krsna-m commented Aug 18, 2023

Not meant to upset, but part of the agreement for the renaming initiative you requested was that you would have to do more than run a simple sed to rename things and help get repos working with the new rename. So far, you have not done any of that which you agreed to and now extra work is landing on us (infra) and repo owners which was something that we explicitly mentioned that we didnt want to see.

@davidhadas
Copy link
Contributor Author

Not meant to upset, but part of the agreement for the renaming initiative you requested was that you would have to do more than run a simple sed to rename things and help get repos working with the new rename. So, far you have not done any of that which you agreed to and now extra work is landing on us (infra) and repo owners which was something that was explicitly we didnt want to see.

That is completely incorrect and represent your own attitude against this effort from day 1.

It was explicitly decided that the responsibility is on the owners of the repos to make the changes

I did volunteer to steer this effort, however given what you wrote, until there is a clear decision on this at the TOC and clear agreement as for repo owners taking responsibility, I am not going to volunteer any more of my time to this effort.

@upodroid
Copy link
Member

upodroid commented Aug 18, 2023

This isn't helpful.

Krsna rightfully felt from the beginning that this was a very large and complex endeavour, but we did a good job so far with mitigating his concerns and delivering it so let's get this over the finish line. The changes the linter is asking for are extremely trivial and far less than we spent on writing these comments.

@davidhadas
Copy link
Contributor Author

no loger relevant

@davidhadas davidhadas closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants