🎁 Don't force the vendoring of deps #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
approved
This was referenced Sep 1, 2023
cardil
force-pushed
the
feature/vendorless-mode
branch
from
b3fc86b
to
a5a1861
Compare
cardil
force-pushed
the
feature/vendorless-mode
branch
from
a5a1861
to
f79fbb4
Compare
cardil
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
commented
Sep 6, 2023
| @@ -4,4 +4,5 @@ use ( | |||
| . | |||
| schema | |||
| test | |||
| test/vendorproj | |||
There was a problem hiding this comment.
For the record: I added this submodule to test if the scripts allow having a mixed project, with some modules having vendor/ and some don't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind enhancement
Fixes #310
Requires #222
Release Note