Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS #351

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[release-1.11] Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS #351

merged 2 commits into from
Nov 23, 2023

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #350

Adding the option to install knative eventing TLS component

Leo6Leo and others added 2 commits November 22, 2023 18:33
@Leo6Leo @knative-prow-robot
Adding the variable to install latest eventing tls
e52c8fe
@Leo6Leo @pierDipi @knative-prow-robot
Update library.sh
63b5233 
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2023
Merged
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2023
@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 22, 2023

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 November 22, 2023 18:41
@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 22, 2023

/cc @pierDipi @creydr

pierDipi
pierDipi approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@pierDipi
Copy link
Member

Since it's unrelated

/override "Code Style / style / suggester / shell"

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 23, 2023

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code Style / style / suggester / shell

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

Since it's unrelated

/override "Code Style / style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

/override "style / suggester / shell"

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 23, 2023

@pierDipi: Overrode contexts on behalf of pierDipi: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit c0f04e8 into knative:release-1.11 Nov 23, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@cardil cardil Awaiting requested review from cardil

@evankanderson evankanderson Awaiting requested review from evankanderson

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@creydr creydr Awaiting requested review from creydr

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @Leo6Leo @pierDipi