Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch releases are incorrectly marked as latest release #201

Closed
dprotaso opened this issue Sep 19, 2023 · 3 comments · Fixed by knative/hack#339
Closed

Patch releases are incorrectly marked as latest release #201

dprotaso opened this issue Sep 19, 2023 · 3 comments · Fixed by knative/hack#339
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dprotaso
Copy link
Member

dprotaso commented Sep 19, 2023

When a patch release (for an older release branch) occurs the hack scripts are marking that as the latest release.

Only patch releases from the latest branch should be marked as the latest release.

@dprotaso
Copy link
Member Author

/assign @kvmware

@dprotaso
Copy link
Member Author

dprotaso commented Sep 19, 2023

eg. when serving cut two point releases for two branches (release-1.10, release-1.11) the release-1.10 branch finished last.

SInce release-1.10 finished last the point release was marked as the latest.

So we have

release order by time
v1.10.0
v1.11.0
v1.11.1
v1.10.0 <-- marked as latest

But I would expect v1.11.1 to be the latest release. I had to manually update this manually by editing the release

@krsna-m
Copy link
Contributor

krsna-m commented Sep 19, 2023

Looks like that hub tool does not have any way to specify a latest (https://hub.github.com/hub-release.1.html) and whatever was touched last becomes the latest. This would have to be tested with maybe a hub edit , after a dot for a older release is done. Otherwise, we might have to switch over to gh cli tool (https://cli.github.com/manual/gh_release_create) that allows a --latest flag.

@cardil cardil added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants