Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function to set latest semver to latest #339

Merged
merged 4 commits into from
Nov 2, 2023
Merged

add function to set latest semver to latest #339

merged 4 commits into from
Nov 2, 2023

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Nov 2, 2023

Changes

  • 🎁 Add function to release.sh to set highest semver as latest in github

Fixes knative/infra#201

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2023
@krsna-m
Copy link
Contributor Author

krsna-m commented Nov 2, 2023

This assumes that jq is available.

@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2023

/assign @cardil @upodroid

@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2023

/approve

will let others add lgtm

@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2023

/cherry-pick release-1.12

@knative-prow-robot
Copy link

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Nov 2, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor Author

krsna-m commented Nov 2, 2023

https://github.com/knative/infra/blob/main/images/prow-tests/Dockerfile#L65

cardil
cardil requested changes Nov 2, 2023
View reviewed changes
release.sh Outdated Show resolved Hide resolved
release.sh Outdated Show resolved Hide resolved
release.sh Outdated Show resolved Hide resolved
krsna-m and others added 2 commits November 2, 2023 13:57
@krsna-m @cardil
Update release.sh
6edbc78 
Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>
@krsna-m @cardil
Update release.sh
ba174d9 
Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>
cardil
cardil reviewed Nov 2, 2023
View reviewed changes
release.sh Outdated Show resolved Hide resolved
cardil
cardil approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Those conditional failures could be dropped, as the set -e should enforce the script will fail at first error, but I can accept this as a defensive touch. They will ensure this works as intended even if this is executed with set +e (unfortunately it might be)

Thanks @kvmware for fixing this!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cardil,dprotaso,kvmware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0d99b7e into knative:main Nov 2, 2023
6 checks passed
@knative-prow-robot
Copy link

@dprotaso: new pull request created: #340

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 2, 2023
Merged
Merged
@knative-prow-robot
Copy link

@dprotaso: new pull request created: #341

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@cardil cardil

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patch releases are incorrectly marked as latest release
5 participants
@krsna-m @dprotaso @knative-prow-robot @cardil @upodroid