Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Golang to 1.21.5 #296

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Bump Golang to 1.21.5 #296

merged 1 commit into from
Dec 7, 2023

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Dec 7, 2023

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2023
upodroid
upodroid approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 30ee442 into knative:main Dec 7, 2023
17 checks passed
@dsimansk dsimansk deleted the pr/bump-go branch December 7, 2023 12:17
@evankanderson
Copy link
Member

Will this automatically cut new releases on Tuesday?

@dprotaso
Copy link
Member

dprotaso commented Dec 7, 2023 •
edited
Loading

No - we need to do noop PRs on various repos - I plan on doing that for serving repos before Tuesday's auto cut.

@dprotaso dprotaso mentioned this pull request Dec 18, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsimansk @evankanderson @dprotaso @upodroid