Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/logging/logging.go imports glog #766

Closed
grantr opened this issue Oct 16, 2019 · 2 comments
Closed

test/logging/logging.go imports glog #766

grantr opened this issue Oct 16, 2019 · 2 comments
Labels
area/test-and-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@grantr
Copy link
Contributor

grantr commented Oct 16, 2019

/area test-and-release
/kind cleanup

Expected Behavior

At some point in the past we removed glog from all our code because it caused a multitude of issues (see kubernetes/kubernetes#61006). Kubernetes created a fork called klog to fix them.

I expect knative projects to not import glog at all, since we use zap (or log when zap is too heavy).

Actual Behavior

test/logging/logging.go imports glog and has no obvious reason to do so. It might just need some cleanup.

/cc @chizhg

@knative-prow-robot knative-prow-robot added area/test-and-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 16, 2019
@coryrc
Copy link
Contributor

coryrc commented Nov 16, 2019

/close

@knative-prow-robot
Copy link
Contributor

@coryrc: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants