Remove reflector metrics

[skonto]

Changes

• Removes the reflector metrics which are not being exposed any more from the client-go lib, see my comment here. I prefer to remove the dead code than simply deactivating with a noop metric provider (we save some allocations as well). Reflector metrics has been deactivated for a long time in client-go, in case they are re-enabled we can discuss the value they bring and if we see fit we can re-enable them.

Fixes #2019

/cc @evankanderson @mattmoor @markusthoemmes

[knative-prow-robot]

Hi @skonto. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skonto]

/retest

[knative-prow-robot]

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[antoineco]

/lgtm

[antoineco]

/ok-to-test

[codecov]

Codecov Report

Merging #2020 (d0f3226) into master (448ae65) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   67.08%   67.03%   -0.05%     
==========================================
  Files         214      213       -1     
  Lines        9080     8986      -94     
==========================================
- Hits         6091     6024      -67     
+ Misses       2714     2687      -27     
  Partials      275      275              

Impacted Files	Coverage Δ
controller/stats_reporter.go	93.75% <ø> (-2.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448ae65...2f2fe38. Read the comment docs.

[evankanderson]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, evankanderson, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• controller/OWNERS [evankanderson]
• metrics/OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment