Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore special errors in codegen for events #2202

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

mattmoor
Copy link
Member

Changes

In #2201 I introduced a wrapped error to requeue keys, but genreconciler emits undesirable InternalError events for this and the NewSkipKey wrapped errors. This squelches those.

/kind bug

Release Note

N/A

Docs

N/A

/assign @vaikas

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 30, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 30, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2202 (6f322d7) into main (3826bb2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   66.00%   65.95%   -0.06%     
==========================================
  Files         220      220              
  Lines        9220     9228       +8     
==========================================
  Hits         6086     6086              
- Misses       2862     2870       +8     
  Partials      272      272              
Impacted Files Coverage Δ
.../injection-gen/generators/reconciler_reconciler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3826bb2...6f322d7. Read the comment docs.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjasonh, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2021
@knative-prow-robot knative-prow-robot merged commit bb4aaf0 into knative:main Jul 30, 2021
@mattmoor mattmoor deleted the no-event-on-requeue branch July 30, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants