Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuthenticatableType duck type #3056

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 14, 2024

Similar to what we have for Addressables, this PR adds the duck type AuthenticatableType for objects, which have a AuthStatus.

In addition it adds a resolver similar to the addressable_resolver to work with this type.

@creydr creydr requested a review from pierDipi June 14, 2024 10:58
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2024
@knative-prow knative-prow bot requested review from aliok, aslom and Leo6Leo June 14, 2024 10:58
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (15e6cdf) to head (8ad286f).

Files Patch % Lines
apis/duck/v1/auth_types.go 0.00% 19 Missing ⚠️
resolver/authenticatable_resolver.go 81.39% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   78.75%   78.62%   -0.14%     
==========================================
  Files         189      191       +2     
  Lines        8872     8934      +62     
==========================================
+ Hits         6987     7024      +37     
- Misses       1620     1642      +22     
- Partials      265      268       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr force-pushed the add-authenticatable-duck-type branch from 87dc325 to 8ad286f Compare June 14, 2024 13:04
@creydr
Copy link
Member Author

creydr commented Jun 14, 2024

/test unit-tests

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

knative-prow bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@knative-prow knative-prow bot merged commit 339c22b into knative:main Jun 14, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants