Let nscert's wildcard certs create secret with domain name instead of…

… the name of namespace (#5539)

Currently wildcard creates secret with the name of its namespace. This
causes error when the secret name is duplicated with other secret
name. In fact, it always fails when domain name is changed.

This patch changes wildcard cert to create secret name with domain
name.

pkg/reconciler/nscert/nscert_test.go

@@ -412,7 +412,7 @@ func knCertWithStatus(namespace *corev1.Namespace, status *v1alpha1.CertificateS
 		},
 		Spec: v1alpha1.CertificateSpec{
 			DNSNames:   wildcardDNSNames,
-			SecretName: namespace.Name,
+			SecretName: defaultCertName,
 		},
 		Status: *status,
 	}

pkg/reconciler/nscert/resources/wildcard_certificate.go

@@ -37,7 +37,7 @@ func MakeWildcardCertificate(namespace *corev1.Namespace, dnsName, domain string
 		},
 		Spec: v1alpha1.CertificateSpec{
 			DNSNames:   []string{dnsName},
-			SecretName: namespace.Name,
+			SecretName: names.WildcardCertificate(dnsName),
 		},
 	}
 }

pkg/reconciler/nscert/resources/wildcard_certificate_test.go

@@ -50,7 +50,7 @@ func TestMakeWildcardCertificate(t *testing.T) {
 		},
 		Spec: v1alpha1.CertificateSpec{
 			DNSNames:   []string{dnsName},
-			SecretName: namespace.Name,
+			SecretName: names.WildcardCertificate(dnsName),
 		},
 	}