Skip to content

Commit

Permalink
Service port names should follow istio-naming convention? (#5070)
Browse files Browse the repository at this point in the history
* update service ports name following istio-naming convention - https://istio.io/docs/setup/kubernetes/additional-setup/requirements/

* update missed and rename service port's name
  • Loading branch information
iamejboy authored and knative-prow-robot committed Nov 15, 2019
1 parent 5617874 commit 6e247eb
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion config/400-activator-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
protocol: TCP
port: 81
targetPort: 8013
- name: metrics
- name: http-metrics
protocol: TCP
port: 9090
targetPort: 9090
Expand Down
2 changes: 1 addition & 1 deletion config/400-controller-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ metadata:
namespace: knative-serving
spec:
ports:
- name: metrics
- name: http-metrics
port: 9090
protocol: TCP
targetPort: 9090
Expand Down
3 changes: 2 additions & 1 deletion config/400-webhook-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ metadata:
namespace: knative-serving
spec:
ports:
- port: 443
- name: https-webhook
port: 443
targetPort: 8443
selector:
role: webhook
4 changes: 2 additions & 2 deletions config/autoscaler-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ spec:
port: 8080
protocol: TCP
targetPort: 8080
- name: metrics
- name: http-metrics
port: 9090
protocol: TCP
targetPort: 9090
- name: custom-metrics
- name: https-custom-metrics
port: 443
protocol: TCP
targetPort: 8443
Expand Down
6 changes: 3 additions & 3 deletions pkg/apis/serving/v1alpha1/revision_lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,19 @@ const (

// QueueAdminPortName specifies the port name for
// health check and lifecycle hooks for queue-proxy.
QueueAdminPortName string = "queueadm-port"
QueueAdminPortName string = "http-queueadm"

// AutoscalingQueueMetricsPortName specifies the port name to use for metrics
// emitted by queue-proxy for autoscaler.
AutoscalingQueueMetricsPortName = "queue-metrics"

// UserQueueMetricsPortName specifies the port name to use for metrics
// emitted by queue-proxy for end user.
UserQueueMetricsPortName = "user-metrics"
UserQueueMetricsPortName = "http-usermetric"

// ServiceQueueMetricsPortName is the name of the port that serves metrics
// on the Kubernetes service.
ServiceQueueMetricsPortName = "metrics"
ServiceQueueMetricsPortName = "http-metrics"
)

var revCondSet = apis.NewLivingConditionSet(
Expand Down

0 comments on commit 6e247eb

Please sign in to comment.