You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the v0.22.0 release I noticed there were a lot of YAML anchors used in https://github.com/knative/serving/releases/download/v0.22.0/serving-core.yaml. The problem appeared when trying to use the manifest as a remote resource using Kustomize for Kubeflow deployments, as Kustomize has problems with YAML anchors (see kubernetes-sigs/kustomize#3675). I assumed the use of YAML anchors was a conscious decision so I didn't think it would make sense to request the removal of anchors.
However, I just noticed that the release file for v0.23.0 contains only 1 YAML anchor for a readinessProbe and livenessProbe at line 4873. This is part of the webhook deployment below. Would it be possible to remove this last YAML anchor so that the KNative release manifests can be used as remote resources in Kustomize?
apiVersion: apps/v1kind: Deploymentmetadata:
name: webhooknamespace: knative-servinglabels:
serving.knative.dev/release: "v0.23.0"spec:
selector:
matchLabels:
app: webhookrole: webhooktemplate:
metadata:
annotations:
cluster-autoscaler.kubernetes.io/safe-to-evict: "false"labels:
app: webhookrole: webhookserving.knative.dev/release: "v0.23.0"spec:
# To avoid node becoming SPOF, spread our replicas to different nodes.affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- podAffinityTerm:
labelSelector:
matchLabels:
app: webhooktopologyKey: kubernetes.io/hostnameweight: 100serviceAccountName: controllercontainers:
- name: webhook# This is the Go import path for the binary that is containerized# and substituted here.image: gcr.io/knative-releases/knative.dev/serving/cmd/webhook@sha256:a276669c3ec2ee82f9399c6e0cc1b1923a16e7341e8973b10eee6a83d9c9ba44resources:
requests:
cpu: 100mmemory: 100Milimits:
cpu: 500mmemory: 500Mienv:
- name: POD_NAMEvalueFrom:
fieldRef:
fieldPath: metadata.name
- name: SYSTEM_NAMESPACEvalueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: CONFIG_LOGGING_NAMEvalue: config-logging
- name: CONFIG_OBSERVABILITY_NAMEvalue: config-observability
- name: WEBHOOK_NAMEvalue: webhook
- name: WEBHOOK_PORTvalue: "8443"# TODO(https://github.com/knative/pkg/pull/953): Remove stackdriver specific config
- name: METRICS_DOMAINvalue: knative.dev/internal/servingsecurityContext:
allowPrivilegeEscalation: falsereadOnlyRootFilesystem: truerunAsNonRoot: truecapabilities:
drop:
- allports:
- name: metricscontainerPort: 9090
- name: profilingcontainerPort: 8008
- name: https-webhookcontainerPort: 8443readinessProbe: &probeperiodSeconds: 1httpGet:
scheme: HTTPSport: 8443httpHeaders:
- name: k-kubelet-probevalue: "webhook"livenessProbe:
!!merge <<: *probefailureThreshold: 6initialDelaySeconds: 20# Our webhook should gracefully terminate by lame ducking first, set this to a sufficiently# high value that we respect whatever value it has configured for the lame duck grace period.terminationGracePeriodSeconds: 300
The text was updated successfully, but these errors were encountered:
Duplicate of #9350.
With the v0.22.0 release I noticed there were a lot of YAML anchors used in https://github.com/knative/serving/releases/download/v0.22.0/serving-core.yaml. The problem appeared when trying to use the manifest as a remote resource using Kustomize for Kubeflow deployments, as Kustomize has problems with YAML anchors (see kubernetes-sigs/kustomize#3675). I assumed the use of YAML anchors was a conscious decision so I didn't think it would make sense to request the removal of anchors.
However, I just noticed that the release file for v0.23.0 contains only 1 YAML anchor for a
readinessProbe
andlivenessProbe
at line 4873. This is part of the webhook deployment below. Would it be possible to remove this last YAML anchor so that the KNative release manifests can be used as remote resources in Kustomize?The text was updated successfully, but these errors were encountered: