Remove YAML anchors from deployments

[davidspek]

Fixes #11468

Proposed Changes

This PR removes two YAML anchors from used in two of the deployment YAML files. This is necessary for the serving-core.yaml file to be compatible with Kustomize. The relevant Kustomize issue regarding YAML anchor support is kubernetes-sigs/kustomize#3675.

Release Note

Remove remaining YAML anchors for comparability with Kustomize.

[knative-prow-robot]

Welcome @davidspek! It looks like this is your first PR to knative/serving 🎉

[knative-prow-robot]

Hi @davidspek. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[julz]

/ok-to-test

To state the obvious it feels like the real fix for this should be in kustomize, but I'd personally be ok with these removals since the anchors don't really add much anyway.

[davidspek]

@julz I completely agree. However, as I mentioned in the issue I created I only brought this up since I noticed almost all use of YAML anchors was removed from the latest KNative release. If that wasn't the case and many YAML anchors were still being used I wouldn't have considered this option.

[codecov]

Codecov Report

Merging #11581 (a605611) into main (2110f33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11581   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files         191      191           
  Lines        9281     9281           
=======================================
  Hits         8144     8144           
- Misses        882      883    +1     
+ Partials      255      254    -1     

Impacted Files	Coverage Δ
pkg/activator/net/revision_backends.go	91.51% <0.00%> (-0.90%)	⬇️
pkg/reconciler/configuration/configuration.go	86.15% <0.00%> (+1.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2110f33...a605611. Read the comment docs.

[davidspek]

/test pull-knative-serving-unit-tests

[davidspek]

@julz Is there an easy way to restart only the failed KinD GitHub action test?

[dprotaso]

I re-kicked the actions.

To @julz's point can you open an issue with kustomize? We might at some point introduce anchors again in the unforeseeable future - we initially had them when we had multiple CRD versions in our resources.

[dprotaso]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidspek]

@dprotaso All the Kustomize issues related to YAML anchors have been combined into kubernetes-sigs/kustomize#3675. As you can see, it is a problem many kustomize users are facing so hopefully it will be addressed. I also don't expect you to refrain from adding YAML anchors in the future. However, if there is a single release that doesn't include them that would be helpful for Kubeflow and KFServing :).

[dprotaso]

yeah sounds good

[dprotaso]

thanks for the PR!