Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the symlinks to vendor directory #14326

Open
Tracked by #134
cardil opened this issue Sep 1, 2023 · 4 comments
Open
Tracked by #134

Remove the symlinks to vendor directory #14326

cardil opened this issue Sep 1, 2023 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link

cardil commented Sep 1, 2023

Expected Behavior

The symlinks used in this repo that targets the vendor directroy should be removed.

Actual Behavior

Serving use symlinks to refer YAML files from networking repo:

$ find . -type l -printf '%p -> ' -exec readlink {} ';' | grep vendor
./config/core/configmaps/network.yaml -> ../../../vendor/knative.dev/networking/config/config-network.yaml
./config/core/300-imagecache.yaml -> ../../vendor/knative.dev/caching/config/image.yaml
./config/core/300-resources/certificate.yaml -> ../../../vendor/knative.dev/networking/config/certificate.yaml
./config/core/300-resources/domain-claim.yaml -> ../../../vendor/knative.dev/networking/config/domain-claim.yaml
./config/core/300-resources/ingress.yaml -> ../../../vendor/knative.dev/networking/config/ingress.yaml
./config/core/300-resources/serverlessservice.yaml -> ../../../vendor/knative.dev/networking/config/serverlessservice.yaml

Ideas

Fold the Networking onto Serving

By folding the networking repo onto Serving repo we would remove the need for symlinks across repos.

Unpack networking YAML files during build

The networking YAML files could be embedded in Go files, and unpacked in Serving in a build process.

@cardil cardil added the kind/bug Categorizes issue or PR as related to a bug. label Sep 1, 2023
@cardil cardil changed the title Resolve the symlinks to vendor directory Remove the symlinks to vendor directory Sep 1, 2023
@dprotaso
Copy link
Member

dprotaso commented Sep 1, 2023

The networking YAML files could be embedded in Go files, and unpacked in Serving in a build process.

I think when we update deps we can just do a curl to fetch the resources

we do this in contour - https://github.com/knative-extensions/net-contour/blob/27833509e18d357b74ef42a53d86ae311ffd6692/hack/update-deps.sh#L34

@dprotaso dprotaso added this to the v1.12.0 milestone Sep 1, 2023
@dprotaso
Copy link
Member

dprotaso commented Sep 1, 2023

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Sep 1, 2023
@dprotaso
Copy link
Member

/assign @cardil

@dprotaso dprotaso removed this from the v1.12.0 milestone Sep 15, 2023
@Priyansurout
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
3 participants