Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack the networking YAML files write them to the config/networking … #14443

Closed

Conversation

Priyansurout
Copy link
Contributor

…directory

Fixes #14326

Proposed Changes

Write a Go script to unpack the networking YAML files. The script should read the networking YAML files from the vendor/knative.dev/networking/config directory and write them to the config/networking directory.
Add

Release Note

NONE

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

Hi @Priyansurout. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Sep 26, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Priyansurout
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (60cb95f) 86.04% compared to head (7adfe43) 86.03%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14443      +/-   ##
==========================================
- Coverage   86.04%   86.03%   -0.02%     
==========================================
  Files         196      196              
  Lines       14874    14871       -3     
==========================================
- Hits        12799    12794       -5     
- Misses       1763     1765       +2     
  Partials      312      312              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Priyansurout Priyansurout deleted the unpack-networking-yamls branch September 26, 2023 15:37
@Priyansurout Priyansurout restored the unpack-networking-yamls branch September 26, 2023 15:37
@Priyansurout Priyansurout deleted the unpack-networking-yamls branch September 26, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the symlinks to vendor directory
1 participant