Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to pull images in 0.6 release #4155

Closed
rymonroe opened this issue May 23, 2019 · 3 comments · Fixed by #4432
Closed

Unable to pull images in 0.6 release #4155

rymonroe opened this issue May 23, 2019 · 3 comments · Fixed by #4432
Labels
area/API API objects and controllers area/build Build topics specifically related to Knative kind/bug Categorizes issue or PR as related to a bug.

Comments

@rymonroe
Copy link

In what area(s)?

/area API
/area build

What version of Knative?

0.6 Istio 1.1.6 installed with mutual TLS enabled.

Expected Behavior

Hello World go example should pull image and run on k8s cluster.

Actual Behavior

Service gets stuck in 'Revision Failed' and Revision reports "Unable to fetch image "/helloworld-go": unsupported MediaType: google/go-containerregistry#377"

Steps to Reproduce the Problem

Follow hello world sample here (https://knative.dev/docs/serving/samples/hello-world/helloworld-go/index.html)
@rymonroe rymonroe added the kind/bug Categorizes issue or PR as related to a bug. label May 23, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/build Build topics specifically related to Knative labels May 23, 2019
@JRBANCEL
Copy link
Contributor

Looking at the code, this error means that the image uses Docker manifest schema v1, and it is not supported.

Are you using an old image, or generating one with an old version of Docker?

This issue is not specific to Knative.

@rymonroe
Copy link
Author

I'm building the image with docker 18.09.1 and have successfully tested same image with previous version 0.5.2. I think this may be caused by how I'm pushing the image which is what I'm looking into now.

@jonjohnsonjr
Copy link
Contributor

I had fixed this, but the fix breaks CRI-O: #3997

@jonjohnsonjr jonjohnsonjr mentioned this issue Jun 19, 2019
Merged
jonjohnsonjr added a commit to jonjohnsonjr/serving that referenced this issue Jun 19, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
fc7ef55 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
@jonjohnsonjr jonjohnsonjr mentioned this issue Jun 19, 2019
Merged
jonjohnsonjr added a commit to jonjohnsonjr/serving that referenced this issue Jun 21, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
48d8f47 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
jonjohnsonjr added a commit to jonjohnsonjr/serving that referenced this issue Jun 24, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
ec74a10 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
jonjohnsonjr added a commit to jonjohnsonjr/serving that referenced this issue Jun 24, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
ace3323 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
jonjohnsonjr added a commit to jonjohnsonjr/serving that referenced this issue Jun 25, 2019
@jonjohnsonjr
Fix tag resolution for schema 1 images
610c5d8 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
knative-prow-robot pushed a commit that referenced this issue Jun 25, 2019
@jonjohnsonjr @knative-prow-robot
Fix tag resolution for schema 1 images (#4432)
5eded04 
Fixes #4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: #3997

For everything else, we'll just use the digest we get back from the
initial request.
hohaichi pushed a commit to hohaichi/serving that referenced this issue Jun 25, 2019
@jonjohnsonjr @hohaichi
Fix tag resolution for schema 1 images (knative#4432)
a7ae05a 
Fixes knative#4155

For fat manifests, we'll fetch an image by platform because CRI-O is
broken: knative#3997

For everything else, we'll just use the digest we get back from the
initial request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API API objects and controllers area/build Build topics specifically related to Knative kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tag resolution for schema 1 manifests jonjohnsonjr/serving
4 participants
@JRBANCEL @jonjohnsonjr @rymonroe @knative-prow-robot