Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates HPA webhook api version #13411

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Updates HPA webhook api version #13411

merged 1 commit into from
Oct 19, 2022

Conversation

psschwei
Copy link
Contributor

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

Fixes issues raised on Slack by @pmbanugo

@psschwei
updates HPA webhook api version
e1dbd97 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 86.51% // Head: 86.50% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e1dbd97) compared to base (0b88704).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13411      +/-   ##
==========================================
- Coverage   86.51%   86.50%   -0.02%     
==========================================
  Files         196      196              
  Lines       14556    14556              
==========================================
- Hits        12593    12591       -2     
- Misses       1665     1667       +2     
  Partials      298      298
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 90.90% <0.00%> (-1.82%) ⬇️
pkg/autoscaler/statserver/server.go 77.77% <0.00%> (-1.49%) ⬇️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmbanugo
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@knative-prow knative-prow bot merged commit a6a18b8 into knative:main Oct 19, 2022
@skonto skonto mentioned this pull request Oct 20, 2022
Closed
skonto added a commit to skonto/serving that referenced this pull request Oct 20, 2022
@skonto
Revert "updates HPA webhook api version (knative#13411)"
697f553 
This reverts commit a6a18b8.
skonto added a commit to skonto/serving that referenced this pull request Oct 21, 2022
@skonto
Revert "updates HPA webhook api version (knative#13411)"
2b89920 
This reverts commit a6a18b8.
@skonto skonto mentioned this pull request Oct 21, 2022
Merged
skonto pushed a commit to skonto/serving that referenced this pull request Oct 27, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
bd0efc0 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Oct 31, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
6878b39 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 1, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
77f7b28 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift/knative-serving that referenced this pull request Nov 4, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
d2082bd 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 14, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
16448eb 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 14, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
b47afa8 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 14, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
17b925c 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 14, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
27a140a 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 14, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
ea31649 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 16, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
dbab400 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 18, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
0d1b23d 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 21, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
359a3bd 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Nov 24, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
af3da46 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 28, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
75ce006 
This reverts commit a6a18b8.
@psschwei psschwei mentioned this pull request Nov 29, 2022
Closed
@psschwei
Copy link
Contributor Author

/cherry-pick release-1.8

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 29, 2022
Merged
@knative-prow-robot
Copy link
Contributor

@psschwei: new pull request created: #13521

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nak3 pushed a commit to nak3/serving that referenced this pull request Nov 30, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
fe8854c 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Nov 30, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
b5df265 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 1, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
aacfec1 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 2, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
ca13a94 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Dec 12, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
6fadaca 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 15, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
128cd89 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 19, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
bd5d0cd 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 20, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
e7f72e7 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Dec 24, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
c3762b9 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Dec 26, 2022
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
5e67e09 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 7, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
959eae6 
This reverts commit a6a18b8.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 11, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
1b198d3 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 14, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
b87b724 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 17, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
f03da1d 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 19, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
040ace9 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 20, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
4650c45 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 21, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
db59c4b 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 23, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
e069029 
This reverts commit a6a18b8.
nak3 pushed a commit to nak3/serving that referenced this pull request Jan 26, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
5add8c3 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Jan 27, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
71df2ab 
This reverts commit a6a18b8.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 30, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
0f23179 
This reverts commit a6a18b8.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Jan 31, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
b756735 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 3, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
e295747 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 4, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
dd33979 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 11, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
25868b1 
This reverts commit a6a18b8.
serverless-qe added a commit to openshift-knative/serving that referenced this pull request Feb 18, 2023
@serverless-qe
Revert "updates HPA webhook api version (knative#13411)"
4434a0d 
This reverts commit a6a18b8.
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Mar 2, 2023
@psschwei @ReToCode
updates HPA webhook api version (knative#13411)
8ae1318 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmbanugo pmbanugo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psschwei @pmbanugo @knative-prow-robot